https://rancher.com/ logo
Title
c

careful-mouse-42236

02/02/2023, 1:12 PM
Admin UI PR#146: would you mind running the pipeline? just to make sure the GitHub action split is ok
If someone has the time to look at the PR, I would be interested to have your feedback but this is not urgent at all
f

faint-optician-47536

02/02/2023, 7:45 PM
Oh I will tomorrow. Ping me again if i forget it
👍 1
Started the pipeline
c

careful-mouse-42236

02/03/2023, 10:09 AM
Thanks! It works 🙂
f

faint-optician-47536

02/06/2023, 1:26 PM
Is this PR ready then?
c

careful-mouse-42236

02/06/2023, 1:29 PM
This one yes, if someone can have a look at it. I'm unable to test the new packaging pipeline though. That's unfortunate but a limitation of GitHub with new pipelines on main branches (but once it's on main we'll be able to run it manually from a branch).
f

faint-optician-47536

02/06/2023, 1:31 PM
yes i know about this problem. Then i will merge it right now and we will give it a go
c

careful-mouse-42236

02/06/2023, 1:32 PM
Thank you but please let me know if some of the changes are not OK for you. If packaging fails I'll make a quick PR right after
I have a doubt about relative path in the Dockerfile, that may fail...
f

faint-optician-47536

02/06/2023, 1:33 PM
we will see
seems that packaging worked?
pushed and tagged as
master
c

careful-mouse-42236

02/06/2023, 1:39 PM
Seems ok... 😅