https://rancher.com/ logo
Title
c

careful-mouse-42236

01/05/2023, 1:41 PM
Git branches: Would it be possible to do some cleaning in the project branches? There are some good candidates for deletion. (BTW hello, I have been invited to the HF party πŸ˜‡)
f

faint-optician-47536

01/05/2023, 4:02 PM
Deleted Stale Branches βœ…
πŸ™Œ 1
c

careful-mouse-42236

01/05/2023, 4:03 PM
Thanks! There's not much I can do right now but I would share what my new eyes can see if that doesn't bother the team
f

faint-optician-47536

01/05/2023, 4:04 PM
That would be very helpful. At least i can not see gargantua from the eyes of a "beginner". Anything that helps us onboard new people will help.
c

careful-mouse-42236

01/05/2023, 4:04 PM
That's my goal! I started a Pull Request with document updates and suggestions
f

faint-optician-47536

01/05/2023, 4:04 PM
I saw that. I already made a comment πŸ˜›
πŸ˜‹ 1
c

careful-mouse-42236

01/05/2023, 4:05 PM
Nice thanks
f

faint-optician-47536

01/05/2023, 4:06 PM
and welcome to the project btw πŸ˜„
πŸ˜„ 1
c

careful-mouse-42236

01/05/2023, 4:13 PM
For the PR it's really for discussion/suggestion and I just started πŸ™‚ Currently I'm trying to make gargantua works on my machine
f

faint-optician-47536

01/05/2023, 4:17 PM
Sure:
Regarding CI/PKG split, it's a best practice from my experience but I can revert it. It was more a suggestion :)
No that is totally fine i just wanted to point out that in the CI part gargantua is build via the pipeline (go build) and then again in the dockerfile. The go build in the pipeline would not be used. Regarding the Dockerfile base. The pipeline runs on a Ubuntu VM - so this should not be an issue using the binary produced in the dockerfile or am i missing smth?
c

careful-mouse-42236

01/05/2023, 4:18 PM
No but it's human proof πŸ™‚ Imagine someone changes the image in GitHub Actions not knowing about the Dockerfile. I'm certainly to hurt by my experience. Don't want to bother you with this, I'll rollback
f

faint-optician-47536

01/05/2023, 4:19 PM
okey i see what you mean.
c

careful-mouse-42236

01/05/2023, 4:19 PM
I like the idea to speed the CI!
f

faint-optician-47536

01/05/2023, 4:19 PM
Yes. It took forever. We just refactored the pipeline during a small hackathon at kubecon
c

careful-mouse-42236

01/05/2023, 4:20 PM
Oh I see, ok I didn't know. Not cool 😞
f

faint-optician-47536

01/05/2023, 4:21 PM
But creating CI and PKG workflows is a good idea. we should do that
c

careful-mouse-42236

01/05/2023, 4:21 PM
If that's ok I can do that for all repos, pipelines is one of my stuff πŸ™‚
f

faint-optician-47536

01/05/2023, 4:22 PM
sure! i am looking forward for your owrk
πŸ™ 1