https://rancher.com/ logo
Join Slack
Powered by
This message was deleted.
# cabpr
a
This message was deleted.
r
Standard is generally to the same versions of k8s.io packages for the CAPI version that is being used.
Or did you mean in terms of “require” sections?
c
No, in the import section of each file I meant
r
Ah, in that case it depends on the project and your configuration of golangci-lint
c
I think I simply have alphabetical, but any empty line would create a new block, alphabetical sorting is only inside a block
r
In CAPA for example we have 3 groups: • standard go packages • all other packages except capi/providers • all sigs.k8s.io/cluster-api packages
and then in each group alphabetical
c
and project imports ? at the end ?
r
Project imports in CAPA are covered in the last group for us but as we are in a different gh org then yes last
I do like having project imports in the last group
c
ok cool, should we write that if anyone wants to contribute?
r
Yes we can add to the contributing guide and also enfore via the linter
c
Oh interesting
I will need to check how to do that on my worktree
r
c
Is the linter capable of reorganizing automatically in an IDE like VScode ?
Nice! very simple at that!
3 Views
Open in Slack
PreviousNext
Powered by