https://rancher.com/ logo
Title
a

astonishing-stone-14417

11/24/2022, 1:20 PM
@cool-thailand-26552 @rapid-van-91305 I left a few comments here https://github.com/rancher-sandbox/cluster-api-provider-rke2/pull/33 but they are not blocking PR merge. I'm in favour in merging it ASAP and improving in smaller steps. We should be able to split the work on the project after merging it.
r

rapid-van-91305

11/24/2022, 1:26 PM
Great, i will have a look in a bit as well.
I agree that we should merge asap
@cool-thailand-26552 @astonishing-stone-14417 - i just added some comments as well. There is nothing that i see as a blocker and we could follow up when merged.
c

cool-thailand-26552

11/24/2022, 3:18 PM
Thanks @rapid-van-91305
I will merge if that's fine with you as well @astonishing-stone-14417
a

astonishing-stone-14417

11/24/2022, 3:18 PM
👍
merge it 😄
c

cool-thailand-26552

11/24/2022, 3:19 PM
👍
small question then, merge commit, squash and merge ?
r

rapid-van-91305

11/24/2022, 3:34 PM
🎉
Squash & merge?
c

cool-thailand-26552

11/24/2022, 3:35 PM
Next time then :-D
a

astonishing-stone-14417

11/24/2022, 3:38 PM
lets sync up tomorrow and split the work a bit
r

rapid-van-91305

11/24/2022, 3:39 PM
Sounds good