Channels
academy
amazon
arm
azure
cabpr
chinese
ci-cd
danish
deutsch
developer
elemental
epinio
espanol
events
extensions
fleet
français
gcp
general
harvester
harvester-dev
hobbyfarm
hypper
japanese
k3d
k3os
k3s
k3s-contributor
kim
kubernetes
kubewarden
lima
logging
longhorn-dev
longhorn-storage
masterclass
mesos
mexico
nederlands
neuvector-security
office-hours
one-point-x
onlinemeetup
onlinetraining
opni
os
ozt
phillydotnet
portugues
rancher-desktop
rancher-extensions
rancher-setup
rancher-wrangler
random
rfed_ara
rio
rke
rke2
russian
s3gw
service-mesh
storage
submariner
supermicro-sixsq
swarm
terraform-controller
terraform-provider-rancher2
terraform-provider-rke
theranchcast
training-0110
training-0124
training-0131
training-0207
training-0214
training-1220
ukranian
v16-v21-migration
vsphere
windows
Title
a
astonishing-stone-14417
11/24/2022, 1:20 PM@cool-thailand-26552 @rapid-van-91305 I left a few comments here https://github.com/rancher-sandbox/cluster-api-provider-rke2/pull/33 but they are not blocking PR merge. I'm in favour in merging it ASAP and improving in smaller steps. We should be able to split the work on the project after merging it.
r
rapid-van-91305
11/24/2022, 1:26 PMGreat, i will have a look in a bit as well.
I agree that we should merge asap
@cool-thailand-26552 @astonishing-stone-14417 - i just added some comments as well. There is nothing that i see as a blocker and we could follow up when merged.
c
cool-thailand-26552
11/24/2022, 3:18 PMThanks @rapid-van-91305
I will merge if that's fine with you as well @astonishing-stone-14417
a
astonishing-stone-14417
11/24/2022, 3:18 PM👍
merge it 😄
c
cool-thailand-26552
11/24/2022, 3:19 PM👍
small question then, merge commit, squash and merge ?
r
rapid-van-91305
11/24/2022, 3:34 PM🎉
Squash & merge?
c
cool-thailand-26552
11/24/2022, 3:35 PMNext time then :-D
a
astonishing-stone-14417
11/24/2022, 3:38 PMlets sync up tomorrow and split the work a bit
r
rapid-van-91305
11/24/2022, 3:39 PMSounds good