https://rancher.com/ logo
#cabpr
Title
# cabpr
a

adamant-kite-43734

11/14/2022, 1:36 PM
This message was deleted.
a

astonishing-stone-14417

11/14/2022, 1:55 PM
you have to sign all commits, but since there are 43 commits maybe it makes sense to squash all of them into 1-2 commits and sign them.
r

rapid-van-91305

11/14/2022, 2:14 PM
Yes i would agree squashing teh commits is preferable. Down to 1 or to a small number that tells a story.
c

cool-thailand-26552

11/14/2022, 2:28 PM
I did sqaush the commits and pushed, it is now doing the CI checks. However, Alex's review was dismissed...
r

rapid-van-91305

11/14/2022, 2:30 PM
Approved
c

cool-thailand-26552

11/14/2022, 2:30 PM
Cool, let's merge! 🙂
r

rapid-van-91305

11/14/2022, 2:30 PM
Go for it
I’ve closed the issues related to this
🙂
c

cool-thailand-26552

11/14/2022, 2:32 PM
👍 Thanks 👍