This message was deleted.
# cabpra
adamant-kite-43734
11/14/2022, 1:36 PMThis message was deleted.
a
astonishing-stone-14417
11/14/2022, 1:55 PMyou have to sign all commits, but since there are 43 commits maybe it makes sense to squash all of them into 1-2 commits and sign them.
r
rapid-van-91305
11/14/2022, 2:14 PMYes i would agree squashing teh commits is preferable. Down to 1 or to a small number that tells a story.
c
cool-thailand-26552
11/14/2022, 2:28 PMI did sqaush the commits and pushed, it is now doing the CI checks. However, Alex's review was dismissed...
r
rapid-van-91305
11/14/2022, 2:30 PMApproved
c
cool-thailand-26552
11/14/2022, 2:30 PMCool, let's merge! 🙂
r
rapid-van-91305
11/14/2022, 2:30 PMGo for it
rapid-van-91305
11/14/2022, 2:32 PMI’ve closed the issues related to this
rapid-van-91305
11/14/2022, 2:32 PM🙂
c
cool-thailand-26552
11/14/2022, 2:32 PM👍 Thanks 👍