https://rancher.com/ logo
Join Slack
Powered by
This message was deleted.
# cabpr
a
This message was deleted.
r
Maybe if they have the same values i’d use just one type / constants
👍 1
c
Most of these were 
bool
that we changed to 
Enum
for best practices, it looks like we would lose the benefit of the change if we do that. Am I wrong ?
Why not just use the 
bool
after all ?
a
I'm not strictly against bools but I've seen cases when they had to be expanded with other options.
r
In CAPA we don’t use Enums for bools
We have something like this:
Copy code
// +kubebuilder:default=false
	DisableVPCCNI bool `json:"disableVPCCNI,omitempty"`
c
OK, let's say : if it is and should always be 
enabled
or 
disabled
, we would just put a 
bool
👍 1
That's probably more readable
r
Yes i would say so
c
OK, cool ... I don't think I can recover an old commit after so many commits in between, so I will just refactor
Open in Slack
PreviousNext
Powered by