https://rancher.com/ logo
Join Slack
Powered by
This message was deleted.
# harvester
a
This message was deleted.
b
@red-king-19196 I hate pinging you like this, but I also don't want to screw y'all up and I know you did my review and the last couple of reviews for the helpers repo.
Specifically: https://github.com/harvester/upgrade-helpers/tree/main/pre-check Where v1.0.3 was the check written for THAT version of Harvester and 1.1.x was also related to Harvester but got used for 1.2 and 1.3.0 upgrades as well.
I think my suggestion is going to be to delete 
v1.*
directories under 
/pre-check
and move the 1.x script to the pre-check directory. If we ever need a 
v2.x
check, then we can make directories again down the road. My thought was to expand the README.md and include permalinks to the older versions via git history so they're still human findable for people who are looking for those versions even though we're years into EOL for those versions. Does that seem sane?
r
Hey @bland-article-62755. Thanks for sharing your thoughts. I know that the version directories are confusing, and I like the idea you proposed. cc @prehistoric-balloon-31801
❤️ 1
FWIW, we’re considering integrating the preflight check script into the new upgrade manager.
🦜 1
b
Mostly I don't want to be off the deep end. 🙂
r
If you already have a plan for this, just go for it. Maybe create a GH issue first 🙂
b
Can do. I was thinking about that as well that way the PR can "resolve" it. 🙂
r
Yep, and that’s how we work on things.
b
I know there's some other people that will probably have good input and have better visibility than just the Slack.
r
Exactly!
b
Sweet. Thanks! Always appreciate you.
🙌 1
Oooh. sorry last thing: No issues are available in 
upgrade-helpers
. I should make one against the 
Harvester
repo right?
r
Yes. Please create issues in the h/h repo. It’s easier to track for us 🙂 Thank you!
🐿️ 1
b
Oof. You ever do a bunch of work and forget to hit send? 🤦
10 Views
Open in Slack
PreviousNext
Powered by