<@U0200LMSGAK> i've gotten check-spelling to do a ...
# rancher-desktop
q
@proud-jewelry-46860 i've gotten check-spelling to do a vaguely reasonable job of checking PR title/descriptions https://github.com/check-spelling-sandbox/supreme-enigma-solid-invention/actions/runs/18225243371/attempts/4#summary-52078808835 Scroll to: Details 🔎 And expand: 📂 unrecognized-spelling-pr-description 📂 unrecognized-spelling-pr-title
Unfortunately, I don't know of a good way to do something like that for commit messages... I need to find someone who might know magic things about github
c
So, what does this have to do with rancher desktop?
q
Rancher desktop uses check-spelling for CI. I'm looking for ways to improve how it works and then that feature could be enabled here if the project wants to.
c
Ahh ok thank you for the context.
p
Hmm, sorry I didn't notice this earlier, but it does look like you have something about commit messages under `unrecognized-spelling-commit-message`:
jups
is not a recognized word.
I do notice that the Unrecognized words section only shows
unrecognized-spelling
and not
…-commit-message
,
…-pr-description
,
…-pr-title
errors though.
Also, FWIW, our org has pushed out restrictions so we no longer use the action (but we run
unknown-words.sh
directly in a normal action step). That's actually better, because it means we can run the spell check before push to reduce silly cycles where we make a PR only to amend it once the CI returns… having things that can only run in CI sucks.
q
Yeah, the constraint about excluding the unrecognized words is because I use that section for
expect
. I might reformulate it as you're the second person to react to that and not many people have seen this very new prototype for the feature. I think as a first iteration to try to address this, I'll probably try adding a single line below the list when those other categories are present noting that it doesn't include items only present in those other cases and suggesting people check details of the step summary.... I'm actually quite happy with how Rancher Desktop wrapped the code. I also don't like wasting CI cycles/having things I can't run on my own. I'd really like to think through a way to let people reuse what you've done. Fwiw, I've enabled immutable releases for my organization, although I haven't made a release using it yet.