any idea on why when I install my extension in ran...
# extensions
m
any idea on why when I install my extension in rancher 2.11, it overrides some icons, but on rancher 2.10 the icons are not override..
s
i'm not sure we officially support overriding icons, so they're subject to change. Can you provide more detail? which icons, did you upgrade shell in your extension?
m
hi @stocky-account-63046 i'm using
@rancher/shell: ^3.0.4
its kinda weird since its not happening in rancher 2.10 instance.. but on our rancher 2.11 instance whenever I install my extension some icons are changed..
s
thanks, can you provide detail on the icons? are they icons you've added in your extension? are they icons in areas that your extension hasn't touched?
m
i'm using rancher icons.. after installing my extension.. the icons were replace e.g. cluster management icon, harvester icon, etc..
this is the expectations..
s
strange. does your extension include a dependency that brings in it's own css, like a component library? do you have any additional styles for those elements? anything with font-family or changes to element classes?
m
hi @stocky-account-63046 i do have a component library,. but I don't have any codes that updates icons.. I do have changes for font-family but its under the component library.. weird thing is, it only happens in rancher 2.11 onwards.. I tried upgrading my rancher/shell to 3.0.5-rc.8 and it changes to a different icons again.
s
it could be something that's brought in via that library. can you check the styles on the icons? where is that class that applies the different icon coming from?
m
hmm, i checked my other library, it was indeed has rancher/icons installed, so I tried upgrading it to the latest 2.0.38 still the icons are changed whenever I installed my extension
s
try clearing your browser cache and reloading. if that fails to show the correct icons you'll need to start grabbing the fonts the browser fetches and investigating which one serves up those odd icons
m
hey @stocky-account-63046 looks like its not browser cache, since my whole team is experiencing it. sorry for the late reply..
s
would you be able to give it a quick try? there's a few possibilities where stale cache would affect everyone. also just ruling out some of the basics
m
I have tried to restart the rancher. I also tried clearing my cache, I even tried it on incognito.. same issue
s
thanks, did you manage to download those fonts and inspect them?
m
I haven't, I will start doing that now..
found the issue now, its due to 2 rancher icons being loaded, 1 was from our custom dependency which installs a rancher icon v2.0.38, while the extension has already a rancher icon from rancher shell which is v2.0.29.. upon checking our yarn.lock, it shows that there were 2 rancher icons and it causes conflicts.
👍 1
s
to confirm, after removing that custom dependency, or updating it, all is well?
m
after updating it the custom dependency... the custom dependency had the rancher/icons set on dependency instead of devDependency so when it was installed in our extension.. it generated another fonts folder.. what I did was move the rancher/icons to devDependency..
s
Ah I see. FWIW you shouldn't need to bring in the rancher icons package, they'll be part of
rancher/shell