Hi, I created a small PR to rancher/dashboard whic...
# extensions
c
Hi, I created a small PR to rancher/dashboard which fixes a Helm chart deployment for our ECI-built extension (https://github.com/rancher/dashboard/pull/14454). I did not see clear instructions which are related to community contributions. Did I miss something? Do you have a page or a draft CONTRIBUTING.md for that? Also, the bot assigned me to the PR, I removed it, I guess it is only for internal employees.
d
You should still assign yourself even though you are not an employee. Please make sure you filled in the checklist at the bottom of your PR and we will review it once we have capacity
c
Thanks! I cannot re-assign myself to the PR anymore. Should I create a new one or some maintainer can re-assign me? Also, since I am not internal, I cannot comment/check on PR milestones.
Thank you!
d
That's good to know. I've updated the milestone. I assume it has been self-reviewed?
c
Kind of. This part of the script was in a different script in @rancher/shell 3.0.4, that was copied to this new place. So I still need to test it with 3.0.5-rc.2
I can do a quick test with the RC
d
Is it something you are able to test with "yarn link"-ing shell or does it need an rc?
c
probably you can test it with yarn link. The scripts are only referenced in the package.json
We kind of forked this part of the package because we are using buildah for extension build and it’s not supported out-of-the-box.
Ok, I changed it to the new RC version and it works, so self review is done
d
Thank you for your contribution!
c
Welcome! Hope I could help