https://rancher.com/ logo
Join Slack
Powered by
Could the `Open WebUI` `SUSE LLC` extension link b...
# rancher-desktop
q
f
@rapid-eye-50641
👀 1
Ideally the link would go to the Docker Hub page for the extension, but this one is published to ghcr.io instead of Docker Hub.
I wonder if the link shouldn't go to a docs page (eventually)?
q
the ghcr.io page is ugly. at least right now the code page is better, but if you have a docs page, that'd probably be best
f
The only docs page we have right now is Working with LLMs using Open WebUI | Rancher Desktop Docs
q
that's much better than the current thing
note that the README.md in the repo should link to that page
f
It is probably still the best target for this link. It will have to be changed in the extension because Rancher Desktop just uses metadata from the extension image
r
@fast-garage-66093, I think the URL is constructed on the fly in Rancher Desktop?
q
@rapid-eye-50641 can you at least add a link to the docs to the readme?
r
Sure @quick-keyboard-83126, consider it done 🙂
🙌 1
f
I don't see where the "More information" link is generated, but it does not seem to be in the metadata.
@rapid-eye-50641 I've added the docs link as the "website" property here:
👍 2
Would be nice if it had a shorter URL, but that's what it is right now
r
f
Found it
Copy code
return this.extension.slug.startsWith('<http://ghcr.io/|ghcr.io/>') ? `https://${ this.extension.slug }` : `<https://hub.docker.com/extensions/${> this.extension.slug }`;
q
🤮
f
q
@fast-garage-66093 add 
#readme
to the ghcr links
f
Doesn't make any difference to me
q
i mean, i'm happy to make a PR for that
f
It literally displays the same page. It doesn't jump to the anchor; doesn't even look like the README has an anchor.
q
oh, xcept it doesn't work
wtf
grr, github's stupid dynamic content means it doesn't actually work
because the anchor isn't present at page load and only arrives later
f
Doesn't work for me. Neither Safari nor Chrome
q
ok, i'll file a bug against github, they should fix that
f
Anyways, the README is not really interesting to the users of the extension. We should figure out a better way to deal with this, but this won't make it into 1.19.1. Feel free to file a bug for it.
In the end the issue is that there is no proper marketplace URL for non-dockerhub extensions
We could invent some convention that the extension can provide a label with the desired URL
We could define 
io.rancherdesktop.extension.moreinfo
and use that value, if it exists.
I'll create an issue for this
q
i was halfway through drafting
but i'm happy to let you do it
f
This is not a critical issue though, so I would not cherry-pick it for a patch release, even if it were implemented in time for it.
f
Hello and good evening all I am new here
😕 1
Open in Slack
PreviousNext
Powered by