https://rancher.com/ logo
Join Slack
Powered by
Hi I have encountered a problem where it is impos...
# discuss-terraform
c
Hi I have encountered a problem where it is impossible to configure the operating system type in the rancher provider, since there is no such parameter (OS type). Because of this, I cannot create a pool of Windows nodes using terraform There are several pull requests in the provider repository that solve this problem for vsphere, but they are all without review. Is there a chance that one of these pull requests will be merged? https://github.com/rancher/terraform-provider-rancher2/pull/1447 https://github.com/rancher/terraform-provider-rancher2/pull/1343
👀 1
Also created an issue in the rancher repository a few months ago, but didn't get any feedback. https://github.com/rancher/rancher/issues/48775
👀 1
b
Sorry for the lack of response on the GitHub issues, we get a lot of issues and I have trouble keeping up.
Your PR seems reasonable, I don't have test infrastructure to validate the change though. Would you mind adding a link to the Rancher API attribute that you are exposing in the issue?
👀 1
Thank you for bringing this up here, I know it can be frustrating to have to go to multiple places to find help, and it seems like you have been waiting for a while on this.
While I look into this, would you mind updating to the latest master and signing your commits?
c
This is not my PR :) It is 
spec.rkeConfig.machinePools[].machineOS
in Cluster resource Also, in some machine configs you can specify the operating system type. In the first pull request, this is implemented for vsphere
b
I have engaged the proper engineering team, I will let you know how it goes.
c
Thank you!
Hi @bumpy-tomato-36167, do you have any idea how much more time it will take for this to be merged? 😅
b
sorry, looks like https://github.com/rancher/terraform-provider-rancher2/pull/1447 was recently approved, I will get it merged. The other PR looks very similar to me, is it necessary?
c
Nope, both PRs solve the same problem
b
excellent, I will close out the other one
I rebased with master, once build and unit tests pass I will merge. We can expect it to be released later this month or the beginning of next month.
c
Sounds great. Thanks!
b
If you would like to test the change, clone the repo and you can build it with "make build-rancher" (just like the CI). Then you can use a dev override to use the local binary of the provider. https://github.com/rancher/terraform-provider-rancher2/blob/master/scripts/run_tests.sh#L44-L48 https://github.com/rancher/terraform-provider-rancher2/blob/master/test/base/base_test.go#L108
Then if you don't mind letting us know if it works for you, that would be great!
👀 1
c
Works as expected 🎉
b
yay! Thank you!
2 Views
Open in Slack
PreviousNext
Powered by