This message was deleted.
# general
a
This message was deleted.
f
Here's an example of what I wound up seeing while doing an upgrade...
I know the mistake I made in the upgrade process. It just seems like it's a very easy thing to do so I wanted to bring it to the attention of the chart maintainers. And fwiw, those screenshots are with the the longhorn/charts added as a repo in the Rancher UI.
I do know that the Rancher chart devs did some work to ensure that
longhorn-crd
was installed prior to
longhorn
. I'm not entirely sure how this check is running, but I'm wondering if it'd be possible to somehow check to make sure the longhorn install didn't come from the longhorn chart repo before allowing it to proceed. https://github.com/rancher/charts/blob/dev-v2.9/charts/longhorn/102.2.3%2Bup1.4.4/templates/validate-install-crd.yaml
b
If anything I'd open it with a PR against the longhorn charts Repo to add wording on the Readme as an adequate warning to use the official packaged charts if you're using Rancher.
s
Unfortunately it's a known issue. In some situations where there are multiple similar charts in different repos, the one wrong is selected https://github.com/rancher/dashboard/issues/9613
f
I wound up posting our details on the rancher/dashboard issue.
I might still open a README update PR, but I feel like that's not going to be a huge help because it doesn't get in the user's face during the upgrade process. They have to wander off the shortest-path to actually see a message like that.
b
I haven't been around that long, but you're the only user I've heard about installing from the repo and overriding the built in charts and sources, so I feel like that's where the wandering off the path actually occurred. It sounds like mixing the charts, not just upgrading is what broke things. ¯\_(ツ)_/¯
f
Yup - mixing charts is indeed what happened, but my point is that the Rancher UI encourages it
And maybe I am the only idiot that clicked through the UI to do an upgrade and thought "huh, the versions look different -- guess that's OK, Rancher has my back" but maybe I should just not expect that to be the case.
b
I don't know if the proper logic can exist to give the warning you're looking for in the UI, but you could potentially head off the problem of chart mixing in the README.md in the chart repository and avoid it that way.
f
That's a fair statement. And for what it's worth, I'm not "overriding the built in charts and sources". I installed Longhorn using that project's instructions and the Rancher UI offered an upgrade which I walked through. I didn't do anything to override a source. I just followed the UI cues like a normal person would.
b
Yeah I totally get that. At that point the Longhorn Project is a third party repo and not the cultivated built in system repo for Rancher (where they do testing and verify upgrades etc). I have no idea how to you program the logic for adequate warnings with third party repos.
f
Giuseppe Leo mentioned this PR: https://github.com/rancher/dashboard/pull/10180
s
We're considering scaling back the feature, given increased chance of false positives (users are now more familiar with helm, adding more repos, there are more alternative repos containing common charts, etc). Unfortunately that won't be until at least 2.10 is out
f
that's understandable