also what would metallb add that the ingress controller does not already provide?

MetalLB is an implantation for a backend for a lb. Nginx controller only manage ingress, they are serving different purposes

Yes i just read the metal lb docs - thanks