https://rancher.com/ logo
Join Slack
Powered by
This message was deleted.
# cabpr
a
This message was deleted.
r
Thanks for the fix @some-addition-13540 👍
I'll have a look at the PR. Would you be able to create an issue and link it to the PR?
And yes we can get it into a patch release for sure 🙂
s
yep
UJpdated the PR now
@rapid-van-91305 could we get it in before the weekend and a 0.2.4 ?
r
I just had a scan through. Looks good to me. I left one comment about moving the validation into the webhooks instead so that the user is informed early of an invalid config:
s
Yah, tried correcting it and adding a test to check for when validation is trriggering but I can't seem to get it right: https://github.com/rancher-sandbox/cluster-api-provider-rke2/pull/251/files#diff-105b184d3d3c2c0d110151d1c851a[…]01a75c7adaef5753dfcf31f3f597483R126
r
I'll have a look......
Open in Slack
PreviousNext
Powered by