This message was deleted.
# hobbyfarma
adamant-kite-43734
10/11/2023, 3:05 PMThis message was deleted.
w
worried-fountain-60974
10/11/2023, 3:51 PM
I can add some color here in a bit
m
millions-lock-30385
10/11/2023, 3:52 PMNo rush. I just wanted to make sure I understood its purpose as I’m restructuring things a bit.
f
faint-optician-47536
10/12/2023, 3:48 PMWe should move this page from setup to another section. We should create another page that lists all available options and their purpose.
The existing settings page is mainly targeted at developers that want to add custom settings to hobbyfarm - not for people installing and using hobbyfarm
m
millions-lock-30385
10/12/2023, 3:50 PMThat’s what I thought as well. I’ve moved it to the Appendix for now, but will most likely move it to the contributors section once that gets flushed out. I’ve flushed out the actual Settings document for the Admin-UI which should allow users/admins to more easily understand the initial setup.
f
faint-optician-47536
10/12/2023, 3:53 PMAppendix seems fine.
faint-optician-47536
10/12/2023, 3:53 PMThank you for your work so far. This is really great!
m
millions-lock-30385
10/12/2023, 3:53 PMAbsolutely. It’s really helped me understand the project at a much deeper level than before.
millions-lock-30385
10/12/2023, 5:12 PMI’ve updated the Settings page so that it now lives under the Contributing section and have flushed it out a bit so it should be more clear than before.
millions-lock-30385
10/12/2023, 5:14 PMOne major take-away I had with the Settings resource is how the variables are all on the top level. For example:
Copy code
apiVersion: <http://hobbyfarm.io/v1|hobbyfarm.io/v1>
dataType: boolean
kind: Setting
metadata:
labels:
<http://hobbyfarm.io/setting-scope|hobbyfarm.io/setting-scope>: public
name: registration-disabled
namespace: hobbyfarm
value: "true"
valueType: scalar Copy code
apiVersion: <http://hobbyfarm.io/v1|hobbyfarm.io/v1>
kind: Setting
metadata:
labels:
<http://hobbyfarm.io/setting-scope|hobbyfarm.io/setting-scope>: public
name: registration-disabled
namespace: hobbyfarm
settings:
dataType: boolean
value: "true"
valueType: scalarf
faint-optician-47536
10/12/2023, 5:23 PM@worried-fountain-60974
w
worried-fountain-60974
10/13/2023, 1:47 PM
We could do this. However it would be a breaking change and would require writing a conversion webhook and adding a v2 CRD
👍 1
2 Views