rancher-users #cabpr

cabpr

astonishing-stone-14417

11/16/2022, 2:40 PM

@cool-thailand-26552 @rapid-van-91305 @astonishing-eve-43840 https://github.com/kubernetes-sigs/cluster-api/pull/7548/

🎉 2

cool-thailand-26552

11/17/2022, 12:29 PM

@astonishing-stone-14417 @rapid-van-91305, our API still does not have

Conditions

and

RKE2ControlPlaneTemplate

structures. Is it okay if these are added with time or should we think about them from the beginning ?

clean-ghost-11464

11/17/2022, 5:27 PM

poke @rapid-computer-4683

astonishing-stone-14417

11/24/2022, 1:20 PM

@cool-thailand-26552 @rapid-van-91305 I left a few comments here https://github.com/rancher-sandbox/cluster-api-provider-rke2/pull/33 but they are not blocking PR merge. I'm in favour in merging it ASAP and improving in smaller steps. We should be able to split the work on the project after merging it.

cool-thailand-26552

11/24/2022, 2:50 PM

@rapid-van-91305 @astonishing-stone-14417 I put a question in the cluster api channel in Kubernetes Slack about a way to get the certificates from the machine instead of generating them like kubeadm or K3s provider. It looks like, though possible, it wouldn't be recommended. I think we will have to stick with the Certificate generation! 😞

👍 2

cool-thailand-26552

11/25/2022, 8:13 AM

@rapid-van-91305 @astonishing-stone-14417 Is there a standard for organizing golang imports in order to avoid merge conflicts?

astonishing-stone-14417

11/25/2022, 11:13 AM

fyi, I'm working on https://github.com/rancher-sandbox/cluster-api-provider-rke2/blob/main/pkg/rke2/config.go , we can use mapstructure to serialize our API into rke2 config yaml, this should help with writing less code.

👍 1

cool-thailand-26552

11/25/2022, 5:38 PM

I have started putting some issues in the repo to help divide the work in independent tasks, most the issues are not yet well described and labeled, I will do some work on that beginning of next week. But, if someone feels comfortable taking up on of those tasks, please do. Thanks @astonishing-stone-14417 who already assigned himself one of those.

helpful-hospital-31287

12/01/2022, 11:16 AM

Hello there 👋 I am new to the community, and I am a contributor to CAPI & CAPG & I would be very happy to contribute to CAPRKE2

👋 1

rapid-van-91305

12/01/2022, 11:18 AM

Welcome @helpful-hospital-31287, great to see you here 👋

😄 1

rapid-van-91305

12/01/2022, 11:19 AM

And thank you for your first PR 🙂

👀 1

helpful-hospital-31287

12/02/2022, 2:36 PM

Any suggestions about the

make target

and

matrix

https://github.com/rancher-sandbox/cluster-api-provider-rke2/pull/52 @rapid-van-91305?

worried-electrician-89379

12/16/2022, 12:04 PM

Hello here as a follow-up to yesterday's meeting, here is the github issue I filed on rancher-webhook https://github.com/rancher/webhook/issues/158 (this is about one issue we hit when creating a Cluster.provisioning.cattle.io resource as a trigger to the workflow implemented by our capi-rancher-import k8s controller)

worried-electrician-89379

12/16/2022, 12:04 PM

@clean-ghost-11464 @rapid-van-91305 ^^

clean-ghost-11464

12/16/2022, 12:07 PM

Thanks @worried-electrician-89379 for bringing this up. @rapid-van-91305 are you going to triage this?

worried-electrician-89379

12/16/2022, 12:15 PM

(Richard already asked me earlier this morning to tag him on the issue)

rapid-van-91305

12/16/2022, 1:09 PM

We should also capture the other issue with the deletion of the CAPI manifests.

worried-electrician-89379

12/16/2022, 1:16 PM

yes, I can file an issue for this one as well

rapid-van-91305

12/16/2022, 1:23 PM

Great, thank you @worried-electrician-89379

worried-electrician-89379

12/16/2022, 1:29 PM

here it is: https://github.com/rancher/rancher/issues/39924

rapid-van-91305

12/16/2022, 1:37 PM

Thanks 👍

careful-piano-35019

12/26/2022, 10:31 AM

fyi https://rancher-users.slack.com/archives/C3ASABBD1/p1671061052806719 in case someone can provide an answer

cool-thailand-26552

03/02/2023, 11:00 AM

Hello Everyone, I am very excited to announce 🎉 🎉 the first pre-version of our ControlPlane/Bootstrap provider for RKE2 🎉🎉 : https://github.com/rancher-sandbox/cluster-api-provider-rke2/releases/tag/v0.1.0-alpha.1 Please do not hesitate to test it and give us your feedback!

cool-thailand-26552

03/02/2023, 11:03 AM

set the channel topic: CABPR stands for CAPI Bootstrap Provider for RKE2 Github Repo: https://github.com/rancher-sandbox/cluster-api-provider-rke2 🎉 🎉 🎉 First pre-alpha version is here 🎉 🎉 🎉

cool-thailand-26552

03/02/2023, 11:03 AM

set the channel description: Cluster API bootstrap provider for RKE2 https://github.com/rancher-sandbox/cluster-api-provider-rke2/releases/tag/v0.1.0-alpha.1

cool-thailand-26552

03/02/2023, 11:03 AM

set the channel description: Cluster API bootstrap provider for RKE2 🎉 🎉 https://github.com/rancher-sandbox/cluster-api-provider-rke2/releases/tag/v0.1.0-alpha.1 🎉 🎉

👏 1

👍 1

best-microphone-20624

03/05/2023, 6:07 AM

Is it on the CAPBR roadmap to support provisioning of hybrid clusters where say control plane nodes are vms provisioned via vsphere and worker nodes are bare metal provisioned via tinkerbell?

rapid-van-91305

03/06/2023, 10:34 AM

@best-microphone-20624 - this isn't on the RKE2 providers roadmap specifically. However, the ability to create mixed-provider clusters is being discussed more generally within CAPI and a feature group has been formed. The goal is that this will be supported at some point in the future across different providers.

rapid-van-91305

03/06/2023, 10:37 AM

It is technically possible now if providers make changes to not tightly couple the machine reconciliation to the same infra cluster. I created a demo last year where the control planes where VMs (using CAPMVM) and the workers where physical machines (using BYOH): https://twitter.com/fruit_case/status/1555554512529653761?s=61&t=zAZ8pZ78GnN59Qr_4a0cXA

best-microphone-20624

03/07/2023, 1:13 AM

Thanks for getting back to me. I'm glad to hear a feature group has been formed to work this capability. Is there any chance my configuration described above would currently work without significant provider changes?